forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: Split FastVizSwitcher into multiple files for readability (a…
- Loading branch information
Showing
4 changed files
with
220 additions
and
165 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
141 changes: 141 additions & 0 deletions
141
superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { useCallback, useEffect, useMemo, useRef, useState } from 'react'; | ||
| import { css, t, useTheme } from '@superset-ui/core'; | ||
| import { usePluginContext } from 'src/components/DynamicPlugins'; | ||
| import { Tooltip } from 'src/components/Tooltip'; | ||
| import { VizTileProps } from './types'; | ||
|
|
||
| export const VizTile = ({ | ||
| isActive, | ||
| isRendered, | ||
| vizMeta, | ||
| onTileClick, | ||
| }: VizTileProps) => { | ||
| const { mountedPluginMetadata } = usePluginContext(); | ||
| const chartNameRef = useRef<HTMLSpanElement>(null); | ||
| const theme = useTheme(); | ||
| const TILE_TRANSITION_TIME = theme.transitionTiming * 2; | ||
| const [tooltipVisible, setTooltipVisible] = useState(false); | ||
| const [isTransitioning, setIsTransitioning] = useState(false); | ||
| const [showTooltip, setShowTooltip] = useState(false); | ||
| const chartName = vizMeta.name | ||
| ? mountedPluginMetadata[vizMeta.name]?.name || `${vizMeta.name}` | ||
| : t('Select Viz Type'); | ||
|
|
||
| const handleTileClick = useCallback(() => { | ||
| onTileClick(vizMeta.name); | ||
| setIsTransitioning(true); | ||
| setTooltipVisible(false); | ||
| setTimeout(() => { | ||
| setIsTransitioning(false); | ||
| }, TILE_TRANSITION_TIME * 1000); | ||
| }, [onTileClick, TILE_TRANSITION_TIME, vizMeta.name]); | ||
|
|
||
| // Antd tooltip seems to be bugged - when elements move, the tooltip sometimes | ||
| // stays visible even when user doesn't hover over the element. | ||
| // Here we manually prevent it from displaying after user triggers transition | ||
| useEffect(() => { | ||
| setShowTooltip( | ||
| Boolean( | ||
| !isTransitioning && | ||
| (!isActive || | ||
| (chartNameRef.current && | ||
| chartNameRef.current.scrollWidth > | ||
| chartNameRef.current.clientWidth)), | ||
| ), | ||
| ); | ||
| }, [isActive, isTransitioning]); | ||
|
|
||
| const containerProps = useMemo( | ||
| () => | ||
| !isActive | ||
| ? { role: 'button', tabIndex: 0, onClick: handleTileClick } | ||
| : {}, | ||
| [handleTileClick, isActive], | ||
| ); | ||
|
|
||
| let tooltipTitle: string | null = null; | ||
| if (showTooltip) { | ||
| tooltipTitle = isRendered | ||
| ? t('Currently rendered: %s', chartName) | ||
| : chartName; | ||
| } | ||
| return ( | ||
| <Tooltip | ||
| title={tooltipTitle} | ||
| onVisibleChange={visible => setTooltipVisible(visible)} | ||
| visible={tooltipVisible && !isTransitioning} | ||
| placement="top" | ||
| mouseEnterDelay={0.4} | ||
| > | ||
| <div | ||
| {...containerProps} | ||
| css={css` | ||
| display: flex; | ||
| align-items: center; | ||
| color: ${theme.colors.grayscale.base}; | ||
| font-weight: ${theme.typography.weights.bold}; | ||
| border-radius: 6px; | ||
| white-space: nowrap; | ||
| overflow: hidden; | ||
| max-width: fit-content; | ||
| ${!isActive && | ||
| css` | ||
| flex-shrink: 0; | ||
| width: ${theme.gridUnit * 6}px; | ||
| background-color: transparent; | ||
| transition: none; | ||
| &:hover svg path { | ||
| fill: ${theme.colors.primary.base}; | ||
| transition: fill ${theme.transitionTiming}s ease-out; | ||
| } | ||
| `} | ||
| ${isActive && | ||
| css` | ||
| width: 100%; | ||
| background-color: ${theme.colors.grayscale.light4}; | ||
| transition: | ||
| width ${TILE_TRANSITION_TIME}s ease-out, | ||
| background-color ${TILE_TRANSITION_TIME}s ease-out; | ||
| cursor: default; | ||
| svg path { | ||
| fill: ${theme.colors.primary.base}; | ||
| } | ||
| `} | ||
| `} | ||
| > | ||
| {vizMeta.icon}{' '} | ||
| <span | ||
| css={css` | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| min-width: 0; | ||
| padding-right: ${theme.gridUnit}px; | ||
| `} | ||
| ref={chartNameRef} | ||
| > | ||
| {chartName} | ||
| </span> | ||
| </div> | ||
| </Tooltip> | ||
| ); | ||
| }; |
38 changes: 38 additions & 0 deletions
38
superset-frontend/src/explore/components/controls/VizTypeControl/constants.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import Icons from 'src/components/Icons'; | ||
| import { VizMeta } from './types'; | ||
|
|
||
| export const FEATURED_CHARTS: VizMeta[] = [ | ||
| { | ||
| name: 'echarts_timeseries_line', | ||
| icon: <Icons.LineChartTile />, | ||
| }, | ||
| { | ||
| name: 'echarts_timeseries_bar', | ||
| icon: <Icons.BarChartTile />, | ||
| }, | ||
| { name: 'echarts_area', icon: <Icons.AreaChartTile /> }, | ||
| { name: 'table', icon: <Icons.TableChartTile /> }, | ||
| { | ||
| name: 'big_number_total', | ||
| icon: <Icons.BigNumberChartTile />, | ||
| }, | ||
| { name: 'pie', icon: <Icons.PieChartTile /> }, | ||
| ]; |
Oops, something went wrong.