fix(empty dashboards): Allow downloading a screenshot of an empty das…

…hboard (apache#30767) Co-authored-by: Geido <[email protected]>
preset-io · Nov 13, 2024 · 58f9be9 · 58f9be9
1 parent a7069e6
commit 58f9be9
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/superset/utils/webdriver.py b/superset/utils/webdriver.py
@@ -379,11 +379,19 @@ def get_screenshot(self, url: str, element_name: str, user: User) -> bytes | Non
                     )
                 )
             except TimeoutException:
-                logger.exception(
-                    "Selenium timed out waiting for chart containers to draw at url %s",
-                    url,
-                )
-                raise
+                # Fallback to allow a screenshot of an empty dashboard
+                try:
+                    WebDriverWait(driver, 0).until(
+                        EC.visibility_of_all_elements_located(
+                            (By.CLASS_NAME, "grid-container")
+                        )
+                    )
+                except:
+                    logger.exception(
+                        "Selenium timed out waiting for dashboard to draw at url %s",
+                        url,
+                    )
+                    raise
 
             try:
                 # charts took too long to load