fix(dashboard): use light muted spinner for group-by display control loading state - #1040
Open
sadpandajoe wants to merge 1 commit into
Open
fix(dashboard): use light muted spinner for group-by display control loading state#1040sadpandajoe wants to merge 1 commit into
sadpandajoe wants to merge 1 commit into
Conversation
…loading state The group-by "Display controls" card rendered its loading spinner with the default (dark, full-opacity) Loading variant while fetching column options, unlike sibling filter bar components which use the muted, inline size="s" variant. Align it with the rest of the filter bar for a consistent, subtle loading indicator.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Group By dashboard display control (rendered under "Display controls" in the filter bar) showed a loading spinner while fetching its column options. It used
<Loading position="inline" />with no size/opacity props, which falls back to the default full-opacity dark Superset spinner — visually out of place for an inline filter-bar control.This changes it to
<Loading position="inline" size="s" muted />, matching the light, subtle spinner used by every sibling component in the filter bar (FilterValue.tsx,Vertical.tsx,Horizontal.tsx) and theLoadingcomponent's own documented guidance for filter bars / inline elements.Customer-reported issue.
TESTING INSTRUCTIONS
Open a dashboard with a native "Group By" filter/display control backed by a dataset that must fetch column options. While it loads, the spinner should now be the light grey (muted, small) spinner rather than the dark Superset spinner. Existing
GroupByFilterCard.test.tsxpasses.ADDITIONAL INFORMATION