Enable travis to run tests #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good |
1 similar comment
|
looks good |
|
Can travis handle a ~2h test run with 4 docker containers? |
|
There's a 50 minute timeout. |
|
we could run just the smoketest |
|
That's a good idea to start. |
kokosing
force-pushed
the
feature_travis
branch
from
9dfb9a2 to
a5fd03d
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
a5fd03d to
97837b7
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
97837b7 to
f0c5b5e
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
f0c5b5e to
d3206ce
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
d3206ce to
e80e9ce
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
e80e9ce to
f0ad3db
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
|
See travis build for current configuration: https://travis-ci.org/Teradata/presto-admin/jobs/116648638 |
kokosing
force-pushed
the
feature_travis
branch
from
f0ad3db to
eb74cbf
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
|
Recent travis build: https://travis-ci.org/Teradata/presto-admin/builds/116667566 |
kokosing
force-pushed
the
feature_travis
branch
from
eb74cbf to
d063c47
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
d063c47 to
d3ea5c2
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 17, 2016
Fixes prestodb#151. Pull request: prestodb#154
|
travis status: https://travis-ci.org/Teradata/presto-admin/builds/116691363 |
kokosing
force-pushed
the
feature_travis
branch
from
d3ea5c2 to
51d1e63
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 18, 2016
Product tests will be using online installer. This is possible by setting PA_TEST_ONLINE_INSTALLER environment variable and using it in prestoadmin_installer.py to select installer. Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
51d1e63 to
c8a19f6
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 18, 2016
Product tests will be using online installer. This is possible by setting PA_TEST_ONLINE_INSTALLER environment variable and using it in prestoadmin_installer.py to select installer. Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
c8a19f6 to
134323c
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 18, 2016
Product tests will be using online installer. This is possible by setting PA_TEST_ONLINE_INSTALLER environment variable and using it in prestoadmin_installer.py to select installer. Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
134323c to
bb5d133
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 18, 2016
Product tests will be using online installer. This is possible by setting PA_TEST_ONLINE_INSTALLER environment variable and using it in prestoadmin_installer.py to select installer. Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
bb5d133 to
c6b0147
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 18, 2016
Product tests will be using online installer. This is possible by setting PA_TEST_ONLINE_INSTALLER environment variable and using it in prestoadmin_installer.py to select installer. Fixes prestodb#151. Pull request: prestodb#154
|
Travis build passes: https://travis-ci.org/Teradata/presto-admin/builds/116847168 @cawallin @mattsfuller @rschlussel Please review this PR one more time. |
|
looks good |
1 similar comment
|
looks good |
| install: | ||
| - pip install --upgrade pip==6.1.1 | ||
| - pip install -r requirements.txt | ||
| script: |
There was a problem hiding this comment.
I just pushed #160 so that when we have future infra issues, we don't fail to build the base image for every test case. This means that the base image needs to be built prior to running the test cases. You can do this with make docker-images, I took a quick look at the travis docs, it looks like that should happen in a before-script section so that if it fails we won't try to run the product tests.
There was a problem hiding this comment.
Great, so now product test execution should take less time, shouldn't it?
| script: | ||
| - | | ||
| if [ -v PRODUCT_TEST_GROUP ]; then | ||
| PRODUCT_TESTS=$(find tests/product/ -name '*py' | grep -v __init__ | xargs wc -l | sort -n | head -n -1 | awk '{print $2}' | awk "NR % 8 == $PRODUCT_TEST_GROUP" | tr '\n' ' ') |
There was a problem hiding this comment.
Suggest combining the last two awk commands into awk "NR % 8 == $PRODUCT_TEST_GROUP { print $2 }", but it's up to you.
Product tests will be using online installer. This is possible by setting PA_TEST_ONLINE_INSTALLER environment variable and using it in prestoadmin_installer.py to select installer. Fixes prestodb#151. Pull request: prestodb#154
kokosing
force-pushed
the
feature_travis
branch
from
c6b0147 to
2907278
Compare
kokosing
added a commit
to Teradata/presto-admin
that referenced
this pull request
Mar 21, 2016
Product tests will be using online installer. This is possible by setting PA_TEST_ONLINE_INSTALLER environment variable and using it in prestoadmin_installer.py to select installer. Fixes prestodb#151. Pull request: prestodb#154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable travis to run tests
Fixes #151.