Return string from validate port #88
Conversation
| @@ -351,6 +351,10 @@ def test_install_interactive_with_hostnames(self): | |||
| self.assert_has_default_connector(container) | |||
| self.assert_has_jmx_connector(container) | |||
|
|
|||
| # make sure that we don't get an error when using the written out | |||
| # configs | |||
| self.run_prestoadmin('server start') | |||
There was a problem hiding this comment.
this is the real rpm not the dummy one?
There was a problem hiding this comment.
we should also make sure there isn't an error (though maybe with @ebd2 's change it'll fail out immediately?)
There was a problem hiding this comment.
yup. It fails if there's an error
The port was being passed to prestoclient instead of the user. In addition to being incorrect, this was causing a TypeError when trying to log the user information if the port was an int. Testing: confirmed error disappered
|
I tracked down that the error was coming from the port being passed in instead of the user. The error came when it tried logging the user information because the user was never expected to be an int, so it wasn't cast as a string first. |
|
do you need to update unit testing? other than that looks good |
|
lgtm |
|
No the unit tests all mock this out. I could add a unit test that just checks that for this function prestoclient is called with these arguments. That seems awfully specific though. |
|
I guess that's fine then... I hate python mocks! |
|
merged |
Validate port was returning an int, which was causing casting problems.
Change to return a string
Testing: unit tests, update product test, manual verification