Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression codec support for PageSerde #24670

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xin-zhang2
Copy link

@xin-zhang2 xin-zhang2 commented Mar 4, 2025

Description

The compression codec for PageSerde is currently hardcoded as LZ4. This PR adds supports for additional codecs, including ZSTD, SNAPPY, LZO, GZIP and ZLIB.

Motivation and Context

#24597

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Replace `exchange.compression-enabled`,  `fragment-result-cache.block-encoding-compression-enabled`, `experimental.spill-compression-enabled` with `exchange.compression-codec`, `fragment-result-cache.block-encoding-compression-codec` to enable compression codec configurations.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Mar 4, 2025
@xin-zhang2 xin-zhang2 marked this pull request as ready for review March 10, 2025 13:24
@xin-zhang2 xin-zhang2 requested a review from presto-oss March 10, 2025 13:24
@prestodb-ci prestodb-ci requested review from a team, zuyu and imsayari404 and removed request for a team March 10, 2025 13:24
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Added a direct link to the property so the reader doesn't have to scroll through the topic. See screenshot.
Screenshot 2025-03-10 at 9 48 05 AM

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants