Skip to content

Upgrade several dependency versions #24971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade several dependency versions #24971

wants to merge 1 commit into from

Conversation

infvg
Copy link
Contributor

@infvg infvg commented Apr 24, 2025 •
edited
Loading

Description

Upgraded several dependencies

Motivation and Context

Upgrading dependencies

Impact

No impact

Test Plan

UTs

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Upgrade slf4j version to 1.7.36
* Upgrade okio-jvm version to 3.9.1
* Upgrade kotlin-stdlib-jdk8 to 1.9.25
* Upgrade netty version to 4.1.119.Final

@infvg infvg requested a review from a team as a code owner April 24, 2025 07:40
@infvg infvg requested a review from jaystarshot April 24, 2025 07:40
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Apr 24, 2025
@prestodb-ci prestodb-ci requested review from a team, ShahimSharafudeen and NivinCS and removed request for a team April 24, 2025 07:40
@infvg infvg changed the title Upgrade okio-jvm version Upgrade several dependency versions Apr 24, 2025
@infvg infvg force-pushed the extensions-upgrades branch from d45da36 to 32f411c Compare April 24, 2025 10:45
@infvg infvg force-pushed the extensions-upgrades branch from 32f411c to 37e965e Compare April 24, 2025 12:08
@ShahimSharafudeen
Copy link
Contributor

@infvg - Why can't we upgrade the slf4j, okio-jvm, and kotlin-stdlib-jdk8 dependencies to higher versions? Is this limitation related to a JDK upgrade? Also, is the kotlin-stdlib-jdk8 dependency compatible with JDK versions higher than 8?

ShahimSharafudeen
ShahimSharafudeen reviewed Apr 25, 2025
View reviewed changes
pom.xml
<groupId>com.facebook.presto</groupId>
<artifactId>presto-base-arrow-flight</artifactId>
<version>${project.version}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this new dependency added to the POM file? Is it necessary to include it, or was it previously resolved transitively?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahimSharafudeen ShahimSharafudeen ShahimSharafudeen left review comments

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot is a code owner automatically assigned from prestodb/committers

@NivinCS NivinCS Awaiting requested review from NivinCS NivinCS was automatically assigned from prestodb/ibm-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infvg @ShahimSharafudeen @prestodb-ci