You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I thought it would be helpful to provide setup instructions for BSD users. Even though we provided that config option to help them, setup still wouldn't be plug-and-play for them. They'd need to dig through closed issues and find that thread.
Disclaimer: I haven't used BSD, but I believe I found the right packages:
I decided to research the scope of generating the RCS Patch Format in pure ELisp today.
What I found was that core packages like ediff also shell out to the diff command. Similar user packages, like Apheleia, take the same approach. My assumption is that, if you use Emacs, you're using tools like ediff, especially if you use Magit since they integrate so well. If the diff dependency was tolerable for those popular tools, then it follows that it's tolerable for this one too.
(As an aside, say that we wanted to implement it anyway! The diff-lisp package seems like it could be a good place to start. That package has an implementation of the Myers diff algorithm in ELisp. It has a function called diff-lisp-emit-diff, which could potentially be refactored to output a diff in the RCS Patch Format rather than the "unified format." For fun, I cloned the repo, gave the RCS spec to an LLM, and asked it to modify diff-lisp to output the diff in that format. I iterated for a bit, but wasn't able to exactly match the output of diff -n; probably possible with more work. In any case, I feel like I'd still trust diff over a new implementation in ELisp, now that I've had a taste for the complexity of these algorithms.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to: #56
I thought it would be helpful to provide setup instructions for BSD users. Even though we provided that config option to help them, setup still wouldn't be plug-and-play for them. They'd need to dig through closed issues and find that thread.
Disclaimer: I haven't used BSD, but I believe I found the right packages:
Maybe @sirn can confirm if these instructions look correct?
As mentioned here, a more portable alternative would be to remove the dependency and diff in elisp. Not sure of the scope on that though.