Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merge/ design_로그인회원가입-퍼블리싱_#12] Design 로그인회원가입 퍼블리싱 #12 #15

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

sunhyeongpp
Copy link
Collaborator

✅ 체크리스트

  • merge할 브랜치의 위치를 확인해주세요 (main ❌)
  • 리뷰어를 프론트 모든 팀원을 선택해주세요.
  • PR의 라벨을 추가해주세요.

✨ 변경 사항

  1. 로그인, 회원가입, 소속 등록 페이지 퍼블리싱했습니다
  2. index.css에 색상 지정했습니다 (색상 명에 하이픈(-)만 사용 가능해서 피그마 색상 명에 ':'부분은 모두 '-'로 대체했습니다)

🔗 관련 이슈

📸 스크린샷 (선택)

스크린샷 2025-02-14 오전 11 14 03 스크린샷 2025-02-14 오전 11 14 11 스크린샷 2025-02-14 오전 11 14 33

@sunhyeongpp sunhyeongpp added the 🎨 Design 디자인 label Feb 14, 2025
@sunhyeongpp sunhyeongpp self-assigned this Feb 14, 2025
@sunhyeongpp sunhyeongpp linked an issue Feb 14, 2025 that may be closed by this pull request
3 tasks
onClick={(e) => (to ? navigate(to) : onClick && onClick(e))}
>
{logo && <img src={logo} />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 이미지태그에 alt속성이 빠진거같아요 !

Copy link
Collaborator

@kkyuheak kkyuheak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~~

@kkyuheak kkyuheak merged commit 49f7e9e into dev Feb 14, 2025
@sunhyeongpp sunhyeongpp deleted the design_로그인회원가입-퍼블리싱_#12 branch February 17, 2025 02:47
sunhyeongpp pushed a commit that referenced this pull request Feb 24, 2025
…_로그인회원가입-퍼블리싱_#12

[merge/ design_로그인회원가입-퍼블리싱_#12] Design 로그인회원가입 퍼블리싱 #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Design 디자인
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: 로그인/회원가입 퍼블리싱
2 participants