-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button: Add clarification on selections #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good! Main concern is the mention of a select
controlling a button label.
content/components/button.mdx
Outdated
@@ -428,6 +428,39 @@ Limit primary button usage. Only use one primary button on the page, whenever po | |||
</Dont> | |||
</DoDontContainer> | |||
|
|||
### Selections | |||
|
|||
Buttons are commonly used to show a choice within a `select`, [SelectPanel](/components/selectpanel) or [ActionMenu](/components/action-menu). In such instances, they are frequently paired with an internal or external label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to show a choice within a
select
When do we use a button to show the selections from a select
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops that was wrong. Removed it. 🙂
Co-authored-by: Mike Perrotti <[email protected]>
Following some confusion in Slack (internally) regarding the display of multiple selections within our buttons, we convened to discuss and concluded that documenting this would be beneficial.