Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on Timeline.Break #850

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Add note on Timeline.Break #850

merged 2 commits into from
Aug 29, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Aug 29, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3355

Clarifies that Timeline.Break should be used for decorative purposes only.

@TylerJDev TylerJDev marked this pull request as ready for review August 29, 2024 13:44
@TylerJDev TylerJDev requested a review from a team as a code owner August 29, 2024 13:44
camertron
camertron approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@camertron camertron merged commit 3ab7a78 into main Aug 29, 2024
6 checks passed
@camertron camertron deleted the add-note-on-timeline-break branch August 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey

@patrickhlauke patrickhlauke Awaiting requested review from patrickhlauke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerJDev @camertron