Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a11y guidelines for required fields #861

Conversation

francinelucca
Copy link
Contributor

@francinelucca francinelucca commented Sep 16, 2024

Closes https://github.com/github/primer/issues/3442
Relates to https://github.com/github/primer/issues/3470
Adds TextArea and FormControl docs for suggestion of adding "Required fields are marked with an asterisk (*)" disclosure when using asterisk (*) to indicate required fields in forms.

@francinelucca francinelucca changed the title WIP: docs(PageHeader): add a11y guidelines for required fieldsd WIP: docs(PageHeader): add a11y guidelines for required fields Sep 17, 2024
@francinelucca francinelucca changed the title WIP: docs(PageHeader): add a11y guidelines for required fields WIP: docs(FormControl): add a11y guidelines for required fields Sep 17, 2024
@francinelucca francinelucca changed the title WIP: docs(FormControl): add a11y guidelines for required fields docs: add a11y guidelines for required fields Sep 18, 2024
@francinelucca francinelucca marked this pull request as ready for review September 18, 2024 19:43
@francinelucca francinelucca requested a review from a team as a code owner September 18, 2024 19:43
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick, thank you 🎉

@francinelucca
Copy link
Contributor Author

Can I get a check on this from @primer/accessibility-design? Thanks! tagging FR @ichelsea

@ichelsea
Copy link
Contributor

This addition LGTM!

@francinelucca francinelucca merged commit 0163f33 into main Sep 20, 2024
6 checks passed
@francinelucca francinelucca deleted the 3470-prcformcontrol-best-practice-use-required-instead-of-an-asterisk-for-required-fields branch September 20, 2024 21:05
Genome23-star added a commit to Genome23-star/design that referenced this pull request Sep 20, 2024
docs: add a11y guidelines for required fields (primer#861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants