-
Notifications
You must be signed in to change notification settings - Fork 52
Update base green 5 #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update base green 5 #1246
Conversation
🦋 Changeset detectedLatest commit: f707815 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the base green 5 color value and refactors the success emphasis background color to use a design token reference instead of a hardcoded value.
- Updates base green 5 color from
#1a7f37
to#1B8238
- Replaces hardcoded color value with token reference
{base.color.green.5}
for bgColor-success-emphasis
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/tokens/base/color/light/light.json5 | Updates the base green 5 color value |
src/tokens/functional/color/bgColor.json5 | Refactors success emphasis to use green 5 token reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Design Token Diff (CSS)
|
Design Token Diff (StyleLint)
|
Design Token Diff (Figma)
|
Summary
This would fixes https://github.com/github/primer/issues/5737
What should reviewers focus on?
Steps to test: