Skip to content

chore(BranchName): Remove the CSS modules feature flag from the BranchName component #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonrohan merged 3 commits into from
Apr 11, 2025
Merged

chore(BranchName): Remove the CSS modules feature flag from the BranchName component #5875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81b36c4
Remove the CSS modules feature flag from the BranchName component
jonrohan Apr 3, 2025
ce662b7
Move BaseComponent out of constructor
jonrohan Apr 10, 2025
9c60c08
Merge branch 'main' into remove_css_modules_flag_branchname
jonrohan Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fancy-webs-hear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Remove the CSS modules feature flag from the BranchName component
50 changes: 9 additions & 41 deletions packages/react/src/BranchName/BranchName.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,26 @@
import React, {type ForwardedRef} from 'react'
import {clsx} from 'clsx'
import styled from 'styled-components'
import {get} from '../constants'
import type {SxProp} from '../sx'
import sx from '../sx'
import {useFeatureFlag} from '../FeatureFlags'
import Box from '../Box'
import classes from './BranchName.module.css'

const StyledBranchName = styled.a<SxProp>`
display: inline-block;
padding: 2px 6px;
font-size: var(--text-body-size-small, ${get('fontSizes.0')});
font-family: var(--fontStack-monospace, ${get('fonts.mono')});
color: var(--fgColor-link, ${get('colors.accent.fg')});
background-color: var(--bgColor-accent-muted, ${get('colors.accent.subtle')});
border-radius: var(--borderRadius-medium, ${get('radii.2')});
text-decoration: none;
&:is(:not(a)) {
color: var(--fgColor-muted);
}
${sx};
`
import {toggleSxComponent} from '../internal/utils/toggleSxComponent'

type BranchNameProps<As extends React.ElementType> = {
as?: As
} & DistributiveOmit<React.ComponentPropsWithRef<React.ElementType extends As ? 'a' : As>, 'as'> &
Omit<SxProp, 'sx'> &
SxProp

const BaseComponent = toggleSxComponent('div') as React.ComponentType<
React.PropsWithChildren<BranchNameProps<React.ElementType> & React.RefAttributes<HTMLElement>>
>

// eslint-disable-next-line @typescript-eslint/no-explicit-any
function BranchName<As extends React.ElementType>(props: BranchNameProps<As>, ref: ForwardedRef<any>) {
const {as: BaseComponent = 'a', className, children, sx, ...rest} = props
const enabled = useFeatureFlag('primer_react_css_modules_ga')

if (enabled) {
if (sx) {
return (
<Box {...rest} ref={ref} as={BaseComponent} className={clsx(className, classes.BranchName)} sx={sx}>
{children}
</Box>
)
}

return (
<BaseComponent {...rest} ref={ref} className={clsx(className, classes.BranchName)}>
{children}
</BaseComponent>
)
}

const {as: Component = 'a', className, children, ...rest} = props
return (
<StyledBranchName {...rest} as={BaseComponent} ref={ref} className={className} sx={sx}>
<BaseComponent as={Component} {...rest} ref={ref} className={clsx(className, classes.BranchName)}>
{children}
</StyledBranchName>
</BaseComponent>
)
}

Expand Down
Loading