Add Modal variant with declarative buttons to PRC SelectPanel#5883
Add Modal variant with declarative buttons to PRC SelectPanel#5883francinelucca merged 27 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 738cb3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
500510a to
94ed190
Compare
|
@francinelucca All comments from #5817 have been addressed here, can I please have a review? |
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/373346 |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
🟢 golden-jobs completed with status |
…t into hectahertz/selectpanel-modal
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Co-authored-by: Marie Lucca <francinelucca@github.com> Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: hectahertz <24622853+hectahertz@users.noreply.github.com>
Note
This is a remake of #5817 to expedite merging to main.
Closes https://github.com/github/primer/issues/4106
Changelog
New
Adds the
modalvariant toSelectPanel, complete withRadioicons.Single select modal
Screen.Recording.2025-04-06.at.18.21.19.mov
Multi select modal
Screen.Recording.2025-04-06.at.18.23.07.mov
See #5817 for all the context.
Shortcut
We are still using
AnchoredOverlayunderneath. But, forvariant=modal, we override its position by directly passingtop,left, etc. tooverlayPropsgoing down to the OverlayThe ideal super clean solution would have been to refactor SelectPanel and conditionally use
useAnchoredPositioninstead of AnchoredOverlay for variant=anchored. Something @siddharthkp attempted in #5230 earlier but had to revert.Rollout strategy
Testing & Reviewing
Merge checklist