-
Notifications
You must be signed in to change notification settings - Fork 627
Remove CircleOcticon
component
#6634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 50b814b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated CircleOcticon
component from the Primer React library as part of a major version release. The component was already marked as deprecated and this removal is part of cleaning up the component library.
- Removes the entire
CircleOcticon
component including source code, tests, stories, and documentation - Updates package exports to no longer include
CircleOcticon
and its types - Removes e2e test configuration for the component
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
script/generate-e2e-tests.js |
Removes CircleOcticon from e2e test generation configuration |
packages/react/src/index.ts |
Removes CircleOcticon exports from package index |
packages/react/src/__tests__/__snapshots__/exports.test.ts.snap |
Updates export snapshot to reflect removed component |
packages/react/src/CircleOcticon/index.ts |
Removes component export file |
packages/react/src/CircleOcticon/CircleOcticon.tsx |
Removes main component implementation |
packages/react/src/CircleOcticon/CircleOcticon.test.tsx |
Removes unit tests |
packages/react/src/CircleOcticon/CircleOcticon.stories.tsx |
Removes Storybook stories |
packages/react/src/CircleOcticon/CircleOcticon.docs.json |
Removes documentation metadata |
e2e/components/CircleOcticon.test.ts |
Removes e2e visual regression tests |
.changeset/cruel-papers-film.md |
Adds changelog entry for major version release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
😢 Hi from github/github-ui. The integration workflow has failed: https://github.com/github/github-ui/actions/runs/17408674313 |
Closes https://github.com/github/primer/issues/5534
Removes
CircleOcticon
from PRC.https://github.com/github/github-ui/pull/1050 needs to be merged before this PR.
Changelog
Removed
CircleOcticon
componentRollout strategy
Testing & Reviewing
Merge checklist