Skip to content

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Aug 21, 2025

Closes https://github.com/github/primer/issues/5534

Removes CircleOcticon from PRC.

https://github.com/github/github-ui/pull/1050 needs to be merged before this PR.

Changelog

Removed

  • Removes CircleOcticon component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Aug 21, 2025

🦋 Changeset detected

Latest commit: 50b814b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 21, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 21, 2025
Copy link
Contributor

github-actions bot commented Aug 21, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.83 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 90 KB (-0.03% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-6634 August 21, 2025 14:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6634 August 21, 2025 14:45 Inactive
@TylerJDev TylerJDev marked this pull request as ready for review August 25, 2025 18:43
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 18:43
@TylerJDev TylerJDev requested a review from a team as a code owner August 25, 2025 18:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated CircleOcticon component from the Primer React library as part of a major version release. The component was already marked as deprecated and this removal is part of cleaning up the component library.

  • Removes the entire CircleOcticon component including source code, tests, stories, and documentation
  • Updates package exports to no longer include CircleOcticon and its types
  • Removes e2e test configuration for the component

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
script/generate-e2e-tests.js Removes CircleOcticon from e2e test generation configuration
packages/react/src/index.ts Removes CircleOcticon exports from package index
packages/react/src/__tests__/__snapshots__/exports.test.ts.snap Updates export snapshot to reflect removed component
packages/react/src/CircleOcticon/index.ts Removes component export file
packages/react/src/CircleOcticon/CircleOcticon.tsx Removes main component implementation
packages/react/src/CircleOcticon/CircleOcticon.test.tsx Removes unit tests
packages/react/src/CircleOcticon/CircleOcticon.stories.tsx Removes Storybook stories
packages/react/src/CircleOcticon/CircleOcticon.docs.json Removes documentation metadata
e2e/components/CircleOcticon.test.ts Removes e2e visual regression tests
.changeset/cruel-papers-film.md Adds changelog entry for major version release

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@TylerJDev TylerJDev added this pull request to the merge queue Sep 2, 2025
@TylerJDev TylerJDev removed this pull request from the merge queue due to a manual request Sep 2, 2025
@primer-integration
Copy link

😢 Hi from github/github-ui. The integration workflow has failed: https://github.com/github/github-ui/actions/runs/17408674313

@TylerJDev TylerJDev added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@TylerJDev TylerJDev added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit d883432 Sep 2, 2025
43 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/remove-circle-octicon branch September 2, 2025 18:22
@primer primer bot mentioned this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants