-
Notifications
You must be signed in to change notification settings - Fork 625
Remove sx props and BoxWithFallback from RadioGroup #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1e13046 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes sx
prop support from the RadioGroup
component and its related sub-components as part of a breaking change. The changes involve replacing styled components with native HTML elements and moving styling to CSS modules.
Key changes:
- Removed
SxProp
from RadioGroup and all CheckboxOrRadioGroup sub-components - Replaced
BoxWithFallback
with nativefieldset
anddiv
elements in CheckboxOrRadioGroup - Updated styled-react package to provide a wrapper for backward compatibility
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/styled-react/src/index.ts | Adds styled RadioGroup wrapper for backward compatibility |
packages/styled-react/src/tests/snapshots/exports.test.ts.snap | Updates export snapshot to reflect RadioGroup position change |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupValidation.tsx | Removes sx prop from validation component |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupLabel.tsx | Removes sx prop from label component |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupCaption.tsx | Removes sx prop from caption component |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx | Replaces BoxWithFallback with native elements and removes sx support |
packages/react/src/RadioGroup/RadioGroup.tsx | Removes SxProp from RadioGroup type definition |
packages/react/src/RadioGroup/RadioGroup.stories.tsx | Removes sx from excluded controls in Storybook |
packages/react/src/CheckboxGroup/CheckboxGroup.dev.stories.tsx | Replaces sx styling with CSS module classes |
packages/react/src/CheckboxGroup/CheckboxGroup.dev.stories.module.css | Adds CSS module for CheckboxGroup dev stories styling |
packages/react/src/Banner/Banner.examples.stories.tsx | Replaces sx prop with CSS module class |
packages/react/src/Banner/Banner.examples.stories.module.css | Adds CSS module for Banner examples styling |
.changeset/quick-bats-remain.md | Documents the breaking change |
Removes support for the
sx
prop from theRadioGroup
component and its related sub-components. Closes #4823sx
props withRadioGroup
.Changelog
SxProp
BoxWithFallback
withfieldset
anddiv
and removedsx
prop supportsx
prop from:sx
in stories and examplesRadioGroup
CheckboxOrRadioGroupCaption
andCheckboxOrRadioGroupLabel