Skip to content

Conversation

mperrotti
Copy link
Contributor

Relates to https://github.com/github/primer/issues/5422

Changelog

New

Changed

Removed

  • sx prop from
    • Select
    • Textarea
    • TextInput
    • TextInputWithTokens
    • TextInputWrapper
  • width, minWidth, and maxWidth props from TextInputWrapper

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: 5934861

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 25, 2025
Copy link
Contributor

github-actions bot commented Aug 25, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.02 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 90.2 KB (-0.03% 🔽)

@mperrotti mperrotti marked this pull request as ready for review August 25, 2025 19:05
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 19:05
@mperrotti mperrotti requested a review from a team as a code owner August 25, 2025 19:05
@mperrotti mperrotti requested a review from jonrohan August 25, 2025 19:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes styled-system usage from TextInputWrapper and related input components as part of the migration away from styled-system dependencies. The changes eliminate the sx prop and width-related props from multiple input components and their wrapper.

  • Removes styled-system imports and SxProp usage from input components
  • Eliminates deprecated width, minWidth, and maxWidth props from TextInputWrapper
  • Updates component type definitions to remove styled-system prop references

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/internal/components/TextInputWrapper.tsx Removes styled-system imports, width props, and sx prop from TextInputBaseWrapper
packages/react/src/Textarea/Textarea.tsx Removes SxProp import and sx prop usage
packages/react/src/TextInputWithTokens/TextInputWithTokens.tsx Removes sx and width-related props from component
packages/react/src/TextInput/TextInput.tsx Removes sx and width props from TextInput component and type definitions
packages/react/src/TextInput/TextInput.docs.json Removes documentation for deprecated width-related props
packages/react/src/TextInput/TextInput.dev.stories.tsx Replaces sx prop usage with CSS classes and updates story structure
packages/react/src/Select/Select.tsx Removes sx prop usage from Select component
packages/react/src/Overlay/Overlay.features.stories.tsx Migrates from sx props to CSS modules and semantic components
packages/react/src/Overlay/Overlay.features.stories.module.css Adds CSS module styles to replace inline sx styling
.changeset/gold-dingos-sneeze.md Documents the major version change for removing styled-system usage
Comments suppressed due to low confidence (1)

packages/react/src/internal/components/TextInputWrapper.tsx:1

  • The style prop is being destructured from props but removed from the component signature. This will cause the prop to be included in restProps and passed to the underlying component, but it's no longer in the type definition. Either remove it from destructuring or add it back to the type definition.
import React, {type ComponentProps} from 'react'

@github-actions github-actions bot requested a deployment to storybook-preview-6666 August 25, 2025 19:11 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant