-
Notifications
You must be signed in to change notification settings - Fork 626
Remove styled-system usage - TextInputWrapper and related #6666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5934861 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request removes styled-system usage from TextInputWrapper and related input components as part of the migration away from styled-system dependencies. The changes eliminate the sx
prop and width-related props from multiple input components and their wrapper.
- Removes styled-system imports and
SxProp
usage from input components - Eliminates deprecated width, minWidth, and maxWidth props from TextInputWrapper
- Updates component type definitions to remove styled-system prop references
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/internal/components/TextInputWrapper.tsx | Removes styled-system imports, width props, and sx prop from TextInputBaseWrapper |
packages/react/src/Textarea/Textarea.tsx | Removes SxProp import and sx prop usage |
packages/react/src/TextInputWithTokens/TextInputWithTokens.tsx | Removes sx and width-related props from component |
packages/react/src/TextInput/TextInput.tsx | Removes sx and width props from TextInput component and type definitions |
packages/react/src/TextInput/TextInput.docs.json | Removes documentation for deprecated width-related props |
packages/react/src/TextInput/TextInput.dev.stories.tsx | Replaces sx prop usage with CSS classes and updates story structure |
packages/react/src/Select/Select.tsx | Removes sx prop usage from Select component |
packages/react/src/Overlay/Overlay.features.stories.tsx | Migrates from sx props to CSS modules and semantic components |
packages/react/src/Overlay/Overlay.features.stories.module.css | Adds CSS module styles to replace inline sx styling |
.changeset/gold-dingos-sneeze.md | Documents the major version change for removing styled-system usage |
Comments suppressed due to low confidence (1)
packages/react/src/internal/components/TextInputWrapper.tsx:1
- The
style
prop is being destructured from props but removed from the component signature. This will cause the prop to be included inrestProps
and passed to the underlying component, but it's no longer in the type definition. Either remove it from destructuring or add it back to the type definition.
import React, {type ComponentProps} from 'react'
Relates to https://github.com/github/primer/issues/5422
Changelog
New
Changed
Removed
sx
prop fromSelect
Textarea
TextInput
TextInputWithTokens
TextInputWrapper
width
,minWidth
, andmaxWidth
props fromTextInputWrapper
Rollout strategy
Testing & Reviewing
Merge checklist