Skip to content

Changed the highlight bg color to use the same as Github #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

adriancuadrado
Copy link
Contributor

Fixes #6797

Copy link
Contributor Author

@adriancuadrado adriancuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't deployed the website locally to make 100% sure about this change, but I think it should work.

@adriancuadrado
Copy link
Contributor Author

Ok, I just tried the change to make sure I didn't break anything and this is the result:

image

And in light mode...

image

@adriancuadrado
Copy link
Contributor Author

I just realized I could change the color to be consistent with the one being used to highlight lines:
image

Im going to change that.

@nikolasburk
Copy link
Member

@adriancuadrado thanks for fixing this 🎉 I just wanted to merge it but I see there's a merge conflict, could you resolve it so this can be merged? 🙏

@adriancuadrado
Copy link
Contributor Author

Wtf the PR is stupidly small. What kind of merge conflict could I possibly have?

@nikolasburk
Copy link
Member

That's true 😅 it shows this:

<<<<<<< patch-3
  --docusaurus-highlighted-code-line-bg: rgba(113, 232, 223, 0.1);
=======
  --docusaurus-highlighted-code-line-bg-dark: rgba(113, 232, 223, 0.1);
  --docusaurus-highlighted-code-line-bg-light: rgba(113, 232, 223, 0.2);
>>>>>>> main
  --ifm-blockquote-border-color: transparent;

I'm not sure what happenned here but it looks like your patch has a docusaurus-highlighted-code-line-bg defined while on main there are dark and light versions of this.

image

@adriancuadrado
Copy link
Contributor Author

@nikolasburk This PR doesn't need to be merged and can be closed because the conflict resolution basically consists of keeping the changes from the main branch.

@adriancuadrado
Copy link
Contributor Author

adriancuadrado commented Apr 15, 2025

@nikolasburk
This is the PR that introduced the change that is conflicting with mine: #6815
That PR also fixes #6797, so yeah we can just close this PR instead.

@mhessdev mhessdev closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlights need more contrast. Specially in dark mode.
3 participants