Skip to content

Ensure that test actually fails when things are broken #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/update-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
type: string
required: true
version:
description: npm version to publish
description: client version to update to and publish
type: string
required: true
secrets:
Expand All @@ -19,10 +19,14 @@ on:
inputs:
npmTag:
description: npm tag to publish to
type: string
type: choice
options:
- latest
- dev
- integration
required: true
version:
description: npm version to publish
description: client version to update to and publish
type: string
required: true

Expand Down Expand Up @@ -93,7 +97,9 @@ jobs:
run: yarn npm publish --tag "$NPM_TAG"

- name: Push
run: git push origin main
env:
GITHUB_REF: ${{ github.ref }}
run: git push origin "$GITHUB_REF"

notify-on-failure:
name: Notify on publish failure
Expand Down
2 changes: 1 addition & 1 deletion example/e2e/starter.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ describe('Example', () => {
});

it('Show basic test passed indicator', async () => {
await expect(element(by.id('test_indicator'))).toBeVisible();
await expect(element(by.id('test_indicator_success'))).toBeVisible();
});
});
4 changes: 2 additions & 2 deletions example/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ export default function App() {
{e2eSuccess ? (
<View
className="rounded-full h-3 w-3 bg-green-500"
testID="test_indicator"
testID="test_indicator_success"
/>
) : (
<View
className="rounded-full h-3 w-3 bg-red-500"
testID="test_indicator"
testID="test_indicator_failure"
/>
)}
</View>
Expand Down
1 change: 1 addition & 0 deletions example/src/db.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import Chance from 'chance';
const chance = new Chance();

const basePrisma = new PrismaClient({
datasourceUrl: 'file:./my-custom.db',
log: [{ emit: 'event', level: 'query' }],
});

Expand Down
Loading