Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bulk-update)!: replace bulk by bulk-update endpoint #15

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

xrutayisire
Copy link
Collaborator

BREAKING CHANGE: drop support for bulk endpoint

  • replace bulk by bulk-update endpoint

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Update everything related to bulk to match new bulk-update endpoint

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

BREAKING CHANGE: drop support for bulk endpoint
Copy link

github-actions bot commented May 29, 2024

size-limit report 📦

Path Size
dist/index.js 1.44 KB (-0.34% 🔽)
dist/index.cjs 1.81 KB (-0.17% 🔽)

@xrutayisire xrutayisire marked this pull request as ready for review May 29, 2024 19:26
Copy link
Member

@angeloashmore angeloashmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few notes about the new error. I'm not sure if it would require a lot of extra work, so I'll leave it up to you whether or not it is worth the effort.

src/client.ts Outdated Show resolved Hide resolved
src/client.ts Show resolved Hide resolved
src/errors.ts Outdated Show resolved Hide resolved
Copy link
Member

@angeloashmore angeloashmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

I left one suggestion about the new error message. I'll let you decide if it's better before merging + publishing.

@angeloashmore angeloashmore changed the title feat(bulk-update): replace bulk by bulk-update endpoint feat(bulk-update)!: replace bulk by bulk-update endpoint May 30, 2024
@xrutayisire xrutayisire merged commit 477d2f7 into main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants