Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle change-case #18

Merged
merged 1 commit into from
Apr 13, 2024
Merged

fix: bundle change-case #18

merged 1 commit into from
Apr 13, 2024

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR change the Vite config to bundle change-case. change-case is now an ESM-only package, but we publish CJS versions of this package. To fix the limitation, we can bundle it within the package.

In the future, we can write our own implementation, or move change-case to a dev dependency.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

Copy link

size-limit report 📦

Path Size
dist/index.js 11.02 KB (-0.12% 🔽)
dist/index.cjs 14.36 KB (-3.1% 🔽)

@angeloashmore angeloashmore merged commit 269dc79 into main Apr 13, 2024
2 checks passed
@angeloashmore angeloashmore deleted the aa/bundle-change-case branch April 13, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant