Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat a custom type model's label property as non-nullable #20

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Apr 26, 2024

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR modifies the return value of model.customType() to ensure its label property is non-nullable.

The existing generator already ensured a value was provided.

Before:

{
  label: string | null | undefined;
}

After:

{
  label: string;
}

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@angeloashmore angeloashmore merged commit 4f7fddd into main Apr 26, 2024
2 checks passed
@angeloashmore angeloashmore deleted the aa/fix-custom-type-model-type branch April 26, 2024 23:02
Copy link

size-limit report 📦

Path Size
dist/index.js 11.02 KB (0%)
dist/index.cjs 14.36 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant