feat: support link text #95
Conversation
There was a problem hiding this comment.
Looks good! I linked to a few suggestions from the @prismicio/react PR (prismicio/prismic-react#205).
Like the @prismicio/react PR, I'm going to mark the PR as "Request changes" because we should publish @prismicio/client first and update the version here before merging. Let me know if you'd like to handle that a different way though.
src/PrismicNextLink.tsx
Outdated
|
|
||
| return ( | ||
| <Link ref={ref} {...attrs} {...restProps} href={href} rel={rel}> | ||
| {children || text} |
There was a problem hiding this comment.
There was a problem hiding this comment.
Replied there 🙂
There was a problem hiding this comment.
Once we resolve the conversation there, I will approve this PR. 🙂
|
@xrutayisire The test was failing because the I knew I had seen the error before! 😄 |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 83.31% 83.54% +0.22%
==========================================
Files 14 14
Lines 1019 1021 +2
Branches 73 74 +1
==========================================
+ Hits 849 853 +4
+ Misses 170 168 -2 ☔ View full report in Codecov by Sentry. |
| @@ -49,7 +49,7 @@ it("creates a redirect with the request's preferred locale", async () => { | |||
|
|
|||
| mockGetRepository({ | |||
| client, | |||
| languages: [{ id: "fr-fr", name: "French (France)" }], | |||
| languages: [{ id: "fr-fr", name: "French (France)", is_master: true }], | |||
There was a problem hiding this comment.
🎉 #nice: Thanks for updating these tests.
Resolves DT-2272
Types of changes
Description
Checklist: