feat(adapter-next): support secret
in /slice-simulator
route
#1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: N/A
Description
This PR adds support for a more secure
/slice-simulator
route in Next.js websites. Both the App Router and Pages Router are supported.This PR includes the following updates:
secret
property to the publicSliceSimulatorParams
type.SLICE_SIMULATOR_SECRET
environment variable.project:init
. Without this change,/slice-simulator
throws an error on fresh projects after running@slicemachine/init
.See this draft documentation for details:
Checklist
Preview
See the above documentation and updated test snapshots.
How to QA 1
Bootstrap a new Next.js app:
Verify http://localhost:3000/slice-simulator loads.
Stop the server and add a
SLICE_SIMULATOR_SECRET
environment variable:Start the server and verify the secret works:
/
Verify the
src/app/slice-simulator/page.tsx
file looks correct and contains no TypeScript errors.Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩