feat: add support for display text in links #1431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dani-mp
reviewed
Aug 23, 2024
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Show resolved
Hide resolved
jomifepe
approved these changes
Aug 26, 2024
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Outdated
Show resolved
Hide resolved
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Outdated
Show resolved
Hide resolved
dani-mp
reviewed
Aug 26, 2024
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/Form.jsx
Show resolved
Hide resolved
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/Form.jsx
Outdated
Show resolved
Hide resolved
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Outdated
Show resolved
Hide resolved
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Show resolved
Hide resolved
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Outdated
Show resolved
Hide resolved
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Show resolved
Hide resolved
xrutayisire
reviewed
Aug 26, 2024
Done ✅ |
dani-mp
approved these changes
Aug 27, 2024
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/Form.jsx
Show resolved
Hide resolved
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Show resolved
Hide resolved
Comment on lines
39
to
45
| checked={Boolean(text)} | ||
| onChange={(event) => { | ||
| void setFieldValue( | ||
| "config.text", | ||
| event.target.checked ? { type: "Text" } : undefined, | ||
| ); | ||
| }} |
support link text with boolean config
# Conflicts: # package.json # packages/slice-machine/package.json # yarn.lock
Use link text in adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: DT-2256
Description
Adds support for the display text property in link fields.
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩