Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for use case templates #36

Merged
merged 41 commits into from
Oct 29, 2018
Merged

Adds support for use case templates #36

merged 41 commits into from
Oct 29, 2018

Conversation

hiimbex
Copy link
Contributor

@hiimbex hiimbex commented Sep 6, 2018

In support of probot/probot#674, this PR aims to accomplish the goals of how the create-probot-app script will access the use case templates. It does so by referencing them locally, and will include them in the npm module.

Right now this PR also includes the code beginnings for several of the use case templates. I'll follow up with separate PRs to update those and add tests for all of them.

@hiimbex hiimbex requested a review from bkeepers October 11, 2018 03:30
@hiimbex hiimbex changed the title [WIP] Adds support for use case templates Adds support for use case templates Oct 15, 2018
Copy link
Contributor

@TimonVS TimonVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I really like that the checks and Git data examples :).
Did a quick review and found some small spelling mistakes.

@hiimbex
Copy link
Contributor Author

hiimbex commented Oct 25, 2018

Thanks @TimonVS!! Spelling is not my strong suit 😅

Copy link
Contributor

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here @hiimbex. I pushed a few commits to tweak the prompt for selecting a template and running the tests. Everything else looks great to me.

README.md Outdated

If you're using npm < 6:
## Getting started with Blue Prints 🛠
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like these examples all make the README harder to grok. I would stick with just the single command, and let the prompts explain the blueprints.

@hiimbex hiimbex merged commit 2fd9172 into master Oct 29, 2018
@hiimbex hiimbex deleted the templatess branch October 29, 2018 19:29
@hiimbex hiimbex mentioned this pull request Nov 1, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants