-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for use case templates #36
Conversation
add deployments example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I really like that the checks and Git data examples :).
Did a quick review and found some small spelling mistakes.
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Co-Authored-By: hiimbex <[email protected]>
Thanks @TimonVS!! Spelling is not my strong suit 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work here @hiimbex. I pushed a few commits to tweak the prompt for selecting a template and running the tests. Everything else looks great to me.
README.md
Outdated
|
||
If you're using npm < 6: | ||
## Getting started with Blue Prints 🛠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like these examples all make the README harder to grok. I would stick with just the single command, and let the prompts explain the blueprints.
In support of probot/probot#674, this PR aims to accomplish the goals of how the create-probot-app script will access the use case templates. It does so by referencing them locally, and will include them in the npm module.
Right now this PR also includes the code beginnings for several of the use case templates. I'll follow up with separate PRs to update those and add tests for all of them.