Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standard linter #7

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Conversation

JasonEtco
Copy link
Member

Use the Standard linter, as per probot/probot#235.

Installs the linter, removes xo and eslint-plugin-probot and fixes all the linting errors/warnings in create-probot-app.js.

Copy link
Contributor

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JasonEtco
Copy link
Member Author

@bkeepers I don't have write access to this repo :( I must have been kicked from the @probot/maintainers group when :octocat: purged my access to everything. Would you mind merging this in?

@hiimbex
Copy link
Contributor

hiimbex commented Sep 6, 2017

@JasonEtco there's an open invite for you to join back!

@wilhelmklopp
Copy link

We really need those organization invite Slack notifications 😆

@JasonEtco
Copy link
Member Author

@hiimbex I saw that, thanks! I still don't have write access for some reason 🤔

@bkeepers
Copy link
Contributor

bkeepers commented Sep 6, 2017

I still don't have write access for some reason 🤔

Fixed. Looked like the @probot/maintainers team wasn't added to this repo.

@JasonEtco JasonEtco merged commit ff4d722 into probot:master Sep 6, 2017
@JasonEtco JasonEtco deleted the standard-linter branch September 6, 2017 15:00
@JasonEtco
Copy link
Member Author

Yay thanks @bkeepers! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants