Fix issue #398 condition never met #446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therewasaguy
reviewed
Jun 1, 2020
There was a problem hiding this comment.
thank you @doriclaudino ! Apologies that this now has merge conflicts. If you can isolate the change to the looper file, that'll help us get this merged.
|
Hi @doriclaudino , can you please look into the merge conflicts, if you are busy I can resolve those conflicts and make a new PR around the same :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (arguments[i] && this.parts[i]) //Condition never metthis.resetParts();//doens't exist on Part prototype and playNextPart already control the flowmaintainers:
Can we normalize CF vs CLRF line endings using git attributes?
got errors on src\audioWorklet\ringBuffer.js
https://github.com/processing/p5.js-sound/issues/398