Fix : [#2986] Add ref callback

[Ri-Sharma]

Fixes #2986

Changes:

1. Added ref callback function to resolve the issue

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number.

[lindapaiste]

Overall this looks good, but I'm not sure what to do with it because we've been working on some larger changes to the tables which would overwrite this. Specifically, the RenameInput and TableWithRename in #2382. (It's been so long that I don't even remember which parts were and were not finished).

If we have this problem in the CollectionListRow then odds are that we also have it in the SketchListRow. Those components are very similar and I don't like the current system where we have to make analogous changes in both places when we see an issue like this.

[lindapaiste]

Does the ref function get executed every time that the element is mounted? Like if you open it and close it and open it again, will it get focused the second time? I think so but I'm not certain off the top of my head.

[Ri-Sharma]

will it get focused the second time?

Yes, it will. The way it works is when the component gets mounted the ref callback is called with the input field as an parameter. And when the component gets unmounted the callback is called again with null as an parameter.

[Ri-Sharma]

If we have this problem in the CollectionListRow then odds are that we also have it in the SketchListRow. Those components are very similar and I don't like the current system where we have to make analogous changes in both places when we see an issue like this.

The SketchListRow is working fine and the problem only exists with the collections. I think this is because the SketchListRow uses class components where as the CollectionListRow uses funtional component and for some reason same logic is working for the classes but not for the functions.

[raclim]

Thanks for your work on this!