Skip to content

Migrate Version URL Parser to TypeScript #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manik-Khajuria-5 wants to merge 3 commits into
base: develop
Choose a base branch
from
+29 −7
Open

Migrate Version URL Parser to TypeScript #3776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8846e86
Migrate Version URL Parser to TypeScript
Manik-Khajuria-5 Jan 5, 2026
a6eb4a2
chore: remove package.json and package-lock.json
Manik-Khajuria-5 Jan 6, 2026
28babc2
feat: parse URL params
Manik-Khajuria-5 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 client/utils/parseURLParams.test.js → client/utils/parseURLParams.test.ts
View file
Open in desktop
File renamed without changes.
36 changes: 29 additions & 7 deletions client/utils/parseURLParams.js → client/utils/parseURLParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import { p5Versions, currentP5Version } from '../../common/p5Versions';

const DEFAULTS = {
interface defaultsTypes {
sound: boolean;
preload: boolean;
shapes: boolean;
data: boolean;
}

const DEFAULTS: defaultsTypes = {
sound: true,
preload: false,
shapes: false,
Expand All @@ -12,7 +19,8 @@ const DEFAULTS = {
* @param {string[]} versions - Array of version strings (e.g., ['1.11.2', '1.11.1'])
* @returns {string} The highest version from the array
*/
function getNewestVersion(versions) {

function getNewestVersion(versions: string[]): string {
return versions.sort((a, b) => {
const pa = a.split('.').map((n) => parseInt(n, 10));
const pb = b.split('.').map((n) => parseInt(n, 10));
Expand All @@ -25,7 +33,7 @@ function getNewestVersion(versions) {
})[0];
}

function validateVersion(version) {
function validateVersion(version: string | null): string {
if (!version) return currentP5Version;

const ver = String(version).trim();
Expand All @@ -36,7 +44,10 @@ function validateVersion(version) {
const majorMinorMatch = /^(\d+)\.(\d+)$/.exec(ver);
if (majorMinorMatch) {
const [, major, minor] = majorMinorMatch;
const matches = p5Versions.filter((v) => {
const versionStrings = p5Versions.map((v) =>
typeof v === 'string' ? v : v.version
);
const matches = versionStrings.filter((v) => {
const parts = v.split('.');
return parts[0] === major && parts[1] === minor;
});
Expand All @@ -49,7 +60,10 @@ function validateVersion(version) {
const majorOnlyMatch = /^(\d+)$/.exec(ver);
if (majorOnlyMatch) {
const [, major] = majorOnlyMatch;
const matches = p5Versions.filter((v) => v.split('.')[0] === major);
const versionStrings = p5Versions.map((v) =>
typeof v === 'string' ? v : v.version
);
const matches = versionStrings.filter((v) => v.split('.')[0] === major);
if (matches.length) {
return getNewestVersion(matches);
}
Expand All @@ -58,7 +72,7 @@ function validateVersion(version) {
return currentP5Version;
}

function validateBool(value, defaultValue) {
function validateBool(value: string | null, defaultValue: boolean): boolean {
if (!value) return defaultValue;

const v = String(value).trim().toLowerCase();
Expand All @@ -72,7 +86,15 @@ function validateBool(value, defaultValue) {
return defaultValue;
}

export function parseUrlParams(url) {
export interface ParsedUrlParams {
version: string;
sound: boolean;
preload: boolean;
shapes: boolean;
data: boolean;
}

export function parseUrlParams(url: string): ParsedUrlParams {
const params = new URLSearchParams(
new URL(url, 'https://dummy.origin').search
);
Expand Down