Skip to content

GSOC-E2E-2: Add unauthenticated save flow test#4204

Open
Geethegreat wants to merge 1 commit into
processing:developfrom
Geethegreat:flow2-clean
Open

GSOC-E2E-2: Add unauthenticated save flow test#4204
Geethegreat wants to merge 1 commit into
processing:developfrom
Geethegreat:flow2-clean

Conversation

@Geethegreat

Copy link
Copy Markdown
Member

Issue:

Fixes #

Demo:

e2e-flow-2.mp4

Changes:

An end-to-end Playwright test covering the unauthenticated save flow.
verifies:

  • The editor loads successfully for an unauthenticated user.
  • The Save option in the File menu is disabled when the user is not logged in.
  • The disabled Save action includes an accessibility label indicating that login is required.
  • Attempting to save a sketch using the keyboard shortcut (Ctrl+S) displays the expected authentication prompt.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Ports the "unauthenticated users cannot save sketches" test from the old
feat/e2e-flow-2 branch onto the new e2e/ scaffolding. Uses .editor-holder
(the container) instead of .CodeMirror/.CodeMirror-code for focusing the
editor before the save shortcut — the .CodeMirror-specific selectors were
the source of the CI flakiness/timeouts diagnosed earlier.
@clairep94

Copy link
Copy Markdown
Collaborator

@raclim this one is ready to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants