Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created data.json for loadJson() #729

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

perminder-17
Copy link
Contributor

When we look at the reference for loadJson, we don't have asset/data.json present. This will probably fix the issue of missing data.json file

@perminder-17
Copy link
Contributor Author

Hi @davepagurek , Feel free to merge this. I have tested it.

Copy link
Collaborator

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perminder-17!

@davepagurek davepagurek merged commit 05435e3 into processing:main Mar 17, 2025
4 checks passed
@davepagurek
Copy link
Collaborator

We're going to be using the 2.0 branch for deploys to the 2.0 website, so I'm going to merge main into 2.0 to have this file in both. For updates that are only needed for 2.0, those can probably be done just into the 2.0 branch.

@perminder-17 perminder-17 deleted the patch-1 branch March 17, 2025 19:58
@perminder-17
Copy link
Contributor Author

We're going to be using the 2.0 branch for deploys to the 2.0 website, so I'm going to merge main into 2.0 to have this file in both. For updates that are only needed for 2.0, those can probably be done just into the 2.0 branch.

Makes a lot of sense! Thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants