Basic functionality of translation tracker #895
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Divyansh013
commented
Jul 6, 2025
Divyansh013
commented
- test-local file detects local changes
- index.js does manual triggering for issue creation
- action works on all "push" events
- Updated translation-sync workflow for examples instead of reference - Added Week 3 test change to Shape Primitives description - Should trigger automated issue creation for outdated translations
- Added workflow_dispatch with scan_all and create_issues options - Can now manually trigger action from GitHub UI - Supports both normal and full-scan modes
- Modified description.mdx to test translation tracker - Should now detect 1 English example file change
- test-local.js: Only shows changed files from predefined test files - index.js: Production mode with minimal console output - Removed verbose logging and repository exploration - Clear distinction: test mode vs production mode with GitHub token
- SCAN_ALL=true environment variable to check all 61 example files - Simplified GitHub Actions workflow - Default: checks only changed files - Manual trigger: option to scan all files
|
Hi @Divyansh013 , this is looking great! Based on checking the current issue created by this (Divyansh013#11) I have a couple of minor suggestions:
|
lirenjie95
reviewed
Jul 17, 2025
Comment on lines
+295
to
+296
| ? 'git diff --name-only HEAD~1 HEAD' | ||
| : 'git diff --name-only HEAD~1 HEAD'; |
There was a problem hiding this comment.
Two options are actually the same. Maybe typo here?
There was a problem hiding this comment.
indeed. What was originally intended here:
'git diff --name-only origin/main...HEAD' // Compare with base branch for PRs
: 'git diff --name-only HEAD~1 HEAD'; // and with last commir for pushes
thoughts about this?
|
|
||
| return null; | ||
| } catch (error) { | ||
| // Fallback to main branch if current branch fails |
There was a problem hiding this comment.
I'm wondering what will happen if the main branch also fails?
There was a problem hiding this comment.
in that case we can log out the error ? or is there something I am missing out?
| try { | ||
| return fs.statSync(filePath).mtime; | ||
| } catch (error) { | ||
| return null; |
There was a problem hiding this comment.
Add log here might be helpful for debugging.
| * Format the issue body with helpful information | ||
| */ | ||
| formatIssueBody(englishFile, language, commitInfo) { | ||
| const translationPath = englishFile.replace('/en/', `/${language}/`); |
There was a problem hiding this comment.
If the directory structure changes or there are multiple occurrences of ·/en/· in the path (correct me if there are any situations that I didn't catch), this could lead to errors or unintended behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.