Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing/Broken links in Arabic docs #7581 #7584

Conversation

swastikCommits
Copy link
Contributor

@swastikCommits swastikCommits commented Feb 28, 2025

Resolves #7581

Changes:
Updated the links that redirected the links to 404

Screenshots of the change:
None

PR Checklist

Copy link

welcome bot commented Feb 28, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@swastikCommits
Copy link
Contributor Author

Maintainers please review it.

@islml
Copy link

islml commented Feb 28, 2025

I think this doesn't solve the issue, links should direct you to pages with same content but in Arabic not the global English ones.

@swastikCommits
Copy link
Contributor Author

I think this doesn't solve the issue, links should direct you to pages with same content but in Arabic not the global English ones.

Can't find the docs for those in arabic language

@islml
Copy link

islml commented Feb 28, 2025

Yes exactly, It's missing, somebody gotta make them.

@ksen0
Copy link
Member

ksen0 commented Feb 28, 2025

Hi @swastikCommits ! Thanks for making this PR. As @islml noted, the issue here is that the Arabic contributor docs need to be created. Is this something you'd be interesting in working on?

@islml
Copy link

islml commented Feb 28, 2025

@ksen0 Yes I would like to work on it in a PR since I'm a native Arabic speaker!

@ksen0
Copy link
Member

ksen0 commented Feb 28, 2025

Alright! I've assigned the original issue to @islml; you can create a PR from your fork whenever you're ready.

@swastikCommits I will close this PR, but please feel free to check out other issues - and also the Contributor Guidelines, especially our policy on waiting for issues to be approve for work and assigned before PR is filed:

You should not “jump the queue” by filing a PR for an issue that either someone else has indicated willingness to submit a contribution or has already been assigned to someone else. We will always prioritize the “first assigned, first serve” order for accepting code contributions for an issue.

@ksen0 ksen0 closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Arabic translations for contributor_docs
3 participants