mouse offscreen behaviors bugfix #8030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksen0
force-pushed
the
8022
branch
2 times, most recently
from
97ba3a0 to
848fe95
Compare
davepagurek
approved these changes
Aug 21, 2025
perminder-17
approved these changes
Aug 21, 2025
Co-authored-by: Perminder Singh <[email protected]>
Co-authored-by: Perminder Singh <[email protected]>
|
Quick update - there's a really weird lag in the locked condition - here's a recording of me moving the mouse at about a constant speed, then requesting pointer lock (iff pink background): Untitled3.movI'm not quite able to reproduce it consistently, for example this sketch which is using the same build at the local version in the video (both at no specific zoom level), doesn't have this: https://editor.p5js.org/ksen0/sketches/jX3A7w1dL EDIT: Occurs specifically when "developer tools" are open, which is the behavior in earlier versions. Therefore, will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8022
Build used by https://editor.p5js.org/ksen0/sketches/jX3A7w1dL - this sketch also allows to manually test movedX/Y with and without pointer lock, at different zoom levels.
The proposed bugfix uses a different moved X/Y mechanism if pointer lock is on or off. The documentation is also updated to more precisely describe behavior during pointerlock.