Friendly errors fix #8224
Friendly errors fix #8224
Conversation
test/unit/core/param_errors.js
Outdated
| test('set() with Boolean (invalid)', function () { | ||
| const result = mockP5Prototype._validate('p5.set', [0, 0, true]); | ||
| assert.equal(result.error, '🌸 p5.js says: Expected number or array or object at the third parameter, but received boolean in p5.set().'); | ||
| assert.equal(result.error, '🌸 p5.js says: Expected array or object at the third parameter, but received boolean in p5.set().'); |
There was a problem hiding this comment.
Was there a reason to alter the tests?
There was a problem hiding this comment.
it passes the test cases.
|
Hi @Nitin2332 , thanks for your effort! Right now, your solution changes the tests to make them pass. The purpose of tests is to ensure stability: if you update this PR, make sure the tests are completely unchanged, and also that all tests pass. This requires using a different fix than the one you proposed. On your prior PR, @perminder-17 has provided some great explanations of how to address the problem. If you can revise this PR to implement those suggestions, I can review it. You are welcome to ask for clarification if you're not sure! However, if the code itself requires many additional iterations, to avoid blocking the project, I’m may have re-assign the issue / open it to other volunteers. |
Nitin2332
force-pushed
the
friendly-error-fix
branch
from
069bdae to
d925a59
Compare
|
Hi @Nitin2332 , I see that you've requested review again, but in this case the tests still don't pass, and you haven't followed up on the detailed review comments. So I will close this PR and reassign the issue. I hope you feel welcome to volunteer on other issues in the future, and we are always happy to help with problems, though it is also important to take feedback and reviews into account. Thank you for understanding! |
3 participants
"resolves #8104"
PR Checklist
npm run lintpasses