-
-
Notifications
You must be signed in to change notification settings - Fork 86
Refactoring SketchException
to be available outside of app
#1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactoring SketchException
to be available outside of app
#1196
Conversation
SketchException
to be available outside of app
Hi @joshgiesbrecht, thank you again for your work on this! I just ran your branch locally and it breaks Android mode since it is looking for the SketchException class but cannot find it within the |
…ly refactored one, so alternate modes don't break.
I think we're good to go now. I wrote a new, very tiny processing.app.SketchException that extends the utils one, so not only does it allow other modes to work but it still plays nicely when testing if something is a processing.utils.SketchException. Once this is released, I'll submit changes to the other modes so they refer directly to the utils class, and when those are released then I'll come back and delete the extra file. Hopefully. Fingers crossed. 😆 |
Thank you @joshgiesbrecht! Not sure if the |
Deprecated marked. I didn't expect the wrappers would be necessary either, but Idea complained and said it was a compile problem, so I let it generate them. 🤷 |
Not sure how to connect this PR in github to the issue, but it's resolving issue #1153 |
Refactored SketchException to live in :app:utils, as per discussion in draft PR #1164. (resubmitted because that draft PR turned into an all-out mess of unrelated commits somehow)
Before merge:
Ant
Closes #1153