Skip to content

Refactoring SketchException to be available outside of app #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joshgiesbrecht
Copy link
Contributor

@joshgiesbrecht joshgiesbrecht commented Aug 1, 2025

Refactored SketchException to live in :app:utils, as per discussion in draft PR #1164. (resubmitted because that draft PR turned into an all-out mess of unrelated commits somehow)

Before merge:

  • Disable/remove GitHub actions related to Ant

Closes #1153

@Stefterv Stefterv marked this pull request as ready for review August 5, 2025 09:02
@Stefterv Stefterv changed the title Sketch exception refactor (new PR) Refactoring SketchException to be available outside of app Aug 5, 2025
@Stefterv
Copy link
Collaborator

Hi @joshgiesbrecht, thank you again for your work on this! I just ran your branch locally and it breaks Android mode since it is looking for the SketchException class but cannot find it within the processing.app. We should keep a SketchException in processing.app and check if it works if it is just an extended version of the processing.utils one.

…ly refactored one, so alternate modes don't break.
@joshgiesbrecht
Copy link
Contributor Author

I think we're good to go now. I wrote a new, very tiny processing.app.SketchException that extends the utils one, so not only does it allow other modes to work but it still plays nicely when testing if something is a processing.utils.SketchException.

Once this is released, I'll submit changes to the other modes so they refer directly to the utils class, and when those are released then I'll come back and delete the extra file. Hopefully. Fingers crossed. 😆

@Stefterv
Copy link
Collaborator

Thank you @joshgiesbrecht! Not sure if the super wrappers are necessary, and could you mark the wrapper class as Deprecated?

@joshgiesbrecht
Copy link
Contributor Author

Deprecated marked. I didn't expect the wrappers would be necessary either, but Idea complained and said it was a compile problem, so I let it generate them. 🤷

@joshgiesbrecht
Copy link
Contributor Author

Not sure how to connect this PR in github to the issue, but it's resolving issue #1153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No stack trace or thrower position highlighting on exception
2 participants