Forward connection pool parameters from django to psycopg #1438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django allows to customize the connection pool through the app settings.
Why not forwarding them to the connection worker for sake of consistency ?
Useful when we want to cap the max_size, as an example.
Not sure how we want to advertise this change in the documentation ?
Maybe the changelog is enough ?
Maybe it's a breaking change if users, suddenly, end up with a connection pool not optimized for the workers.
Successful PR Checklist:
PR label(s):