Skip to content

Conversation

@ticosax
Copy link
Contributor

@ticosax ticosax commented Aug 14, 2025

Django allows to customize the connection pool through the app settings.
Why not forwarding them to the connection worker for sake of consistency ?

Useful when we want to cap the max_size, as an example.

Not sure how we want to advertise this change in the documentation ?
Maybe the changelog is enough ?
Maybe it's a breaking change if users, suddenly, end up with a connection pool not optimized for the workers.

⚠️ Only psycopg is supported, as I don't think using django + aiopg is a thing. I could be wrong though.

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@ticosax ticosax requested a review from a team as a code owner August 14, 2025 08:29
@github-actions github-actions bot added the PR type: miscellaneous 👾 Contains misc changes label Aug 14, 2025
@ticosax ticosax force-pushed the check-connection-pool branch from 3b4c7be to 3863047 Compare August 14, 2025 10:45
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :) I'm seeing some tests fail ?

I'm really sorry that it took so long to review. My energy for doing reviews on my spare time is scarce these days 😅 . Your contribution is appreciated though.

I don't think using django + aiopg is a thing

No it's not, what you did makes sense. Also... I'm considering dropping non-psycopg3 so as to reduce maintenance burden.

@ticosax ticosax force-pushed the check-connection-pool branch from 3863047 to 354de51 Compare October 8, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR type: miscellaneous 👾 Contains misc changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants