Make _wrap_json methods public #1480
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way wrap_json is easier to reuse
denisSurkov
commented
Nov 9, 2025
| assert result["a"].obj == {"b": "c"} | ||
|
|
||
|
|
||
| def test_wrap_json_makes_correct_psycopg_dict__inner_list(): |
Author
There was a problem hiding this comment.
Tests are pretty simple and straightforward. But if you know how to make it better, i will do
Author
|
@medihack , I made PoC with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way wrap_json is easier to reuse.
This is simple proof of concept with Psycopg connector. If it looks okey, I will do the same with other connectors.
I don't want to place
_wrap_jsonsomewhere else. I think it is convenient to call it with context this is wrap json related to psycopg (or other connector).Discussion: #1479
Successful PR Checklist:
PR label(s):