Skip to content

Fixed bug where @current_count not initialized. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fz-ryanbigg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bug where @current_count not initialized. #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/cb2/strategies/percentage.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ def count

def should_open?(error_count)
# do not open until we have a reasonable number of requests
return false if @current_count < 5
return false if self.count < 5

error_perc = error_count * 100 / @current_count.to_f
error_perc = error_count * 100 / self.count.to_f
return error_perc >= threshold
end
end