[Chef] Create a ContactSensor to support LIT ICD （Linux Only) #37123
+6,172
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #37123: Size comparison from b02badf to 91317d1 Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #37123: Size comparison from b02badf to ef66372 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 21, 2025
|
PR #37123: Size comparison from 577b3f2 to 0cc62c4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37123: Size comparison from 94a47ad to 387f7f2 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
examples/chef/linux/main.cpp
Outdated
| @@ -49,6 +57,10 @@ int main(int argc, char * argv[]) | |||
| cmd_app_server_init(); | |||
| #endif | |||
|
|
|||
| #if CHIP_CONFIG_ENABLE_ICD_CIP | |||
| DeviceLayer::SystemLayer().StartTimer(chip::System::Clock::Milliseconds32(CHIP_CONFIG_ICD_IDLE_MODE_DURATION_SEC*1000), notifyIcdActive, nullptr); | |||
There was a problem hiding this comment.
Having this timer here feels 100% wrong. Why is this in main? Why does it notify forever?
There was a problem hiding this comment.
For Linux we don't have a hardware button to trigger the wake up to send Check-in message. So the simplest way is setting a timer periodically wake up and do that.
|
PR #37123: Size comparison from 652f786 to 4ccb849 Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37123: Size comparison from b56134c to aa2cae7 Full report (3 builds for cc32xx, stm32)
|
|
PR #37123: Size comparison from c0e580c to 02b04ca Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
compilation arguments
| @@ -32,3 +32,6 @@ | |||
|
|
|||
| // Allows app options (ports) to be configured on launch of app | |||
| #define CHIP_DEVICE_ENABLE_PORT_PARAMS 1 | |||
|
|
|||
| // Enable subscriptions synchronization | |||
| #define CHIP_CONFIG_SYNCHRONOUS_REPORTS_ENABLED 1 | |||
There was a problem hiding this comment.
SHould this only be enabled for LIT ICD?
examples/chef/linux/main.cpp
Outdated
|
|
||
| ChipLogDetail(Shell, "Periodic wakeup to notify ICD active"); | ||
| DeviceLayer::SystemLayer().StartTimer( | ||
| chip::System::Clock::Milliseconds32(LinuxDeviceOptions::GetInstance().icdPeriodicWakeupDurationMs), notifyIcdActive, |
There was a problem hiding this comment.
This can only be sent if the device has no subscriber.
examples/chef/linux/main.cpp
Outdated
Comment on lines
65
to
68
| #if CHIP_CONFIG_ENABLE_ICD_CIP | ||
| // Send notification right away after init | ||
| DeviceLayer::SystemLayer().StartTimer(chip::System::Clock::Milliseconds32(0), notifyIcdActive, nullptr); | ||
| #endif // CHIP_CONFIG_ENABLE_ICD_CIP |
There was a problem hiding this comment.
This does not belong in main.cpp. Please create a new LIT ICD management file under chef/linux/
Comment on lines
+399
to
+410
| #if CHIP_CONFIG_ENABLE_ICD_SERVER | ||
| " --icdActiveModeDurationMs <icdActiveModeDurationMs>\n" | ||
| " Sets the ICD active mode threshold (in milliseconds). (Default: 300) \n" | ||
| " This defines the how long the the server typically will stay in active mode after \n" | ||
| " initial transition out of idle mode.\n" | ||
| " --icdIdleModeDuration <icdIdleModeDuration>\n" | ||
| " Sets the ICD idle mode durations (in seconds). (Default: 300) \n" | ||
| " This defines the how long the ICD server can stay in idle mode.\n" | ||
| " --icdPeriodicWakeupDurationMs <icdPeriodicWakupDurationMs>\n" | ||
| " Sets the ICD periodic wakeup (in milliseconds). (Default: 60000)\n" | ||
| " This is for testing purpose on Linux which defines the internal to wakeup periodically to send \n" | ||
| " Check-In messages since Linux application doesn't have a physical button to trigger wakeup\n" |
There was a problem hiding this comment.
The button to trigger wake should not be simulated periodically.
Also please clarify between LIT ICD and SIT ICD. The features enabled here are LIT ICD specific for our purposes.
|
PR #37123: Size comparison from c0e580c to 0c37543 Full report (3 builds for cc32xx, stm32)
|
|
PR #37123: Size comparison from c0e580c to 359366a Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a Chef ContactSensor to support LIT ICD .
Testing
For example: the following command to build and run ICD