Adding MRP analytics delegate #37439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a starting point for MRP events to be sent to some sort of delegate interested. The design is intentionally done in this way to reduce code size within the SDK and is meant for applications such as a controller to registers a delegate for MRP events allowing for it to construct analytics.
|
Review changes with |
tehampson
commented
Feb 6, 2025
| kRetransmission, | ||
| kAcknowledged, | ||
| kFailed, | ||
| kUndefined, /* Should be last element in enum */ |
There was a problem hiding this comment.
Maybe this should be the first element 🤷
tehampson
commented
Feb 6, 2025
| @@ -511,6 +546,22 @@ void ReliableMessageMgr::CalculateNextRetransTime(RetransTableEntry & entry) | |||
| peerIsActive = sessionHandle->AsUnauthenticatedSession()->IsPeerActive(); | |||
| } | |||
|
|
|||
| // For initial send the packet has already been submitted to transport layer successfully. | |||
There was a problem hiding this comment.
How do people feel about the location of this and how re-transmission has technically not taken place yet
|
PR #37439: Size comparison from a38f2aa to 1942b8c Full report (3 builds for cc32xx, stm32)
|
|
PR #37439: Size comparison from a38f2aa to 2c393c9 Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, psoc6, qpg, stm32, telink, tizen)
|
tehampson
commented
Feb 6, 2025
| // reason, so saying we have sent re-transmit here is a little presumptuous. | ||
| if (mAnalyticsDelegate) | ||
| { | ||
| ReliableMessageAnalyticsDelegate::TransmitEvent event = { |
There was a problem hiding this comment.
TODO needs to move outside of CHIP_PROGRESS_LOGGING
tehampson
commented
Feb 6, 2025
| @@ -155,6 +155,17 @@ void ReliableMessageMgr::ExecuteActions() | |||
| Transport::GetSessionTypeString(session), fabricIndex, ChipLogValueX64(destination), | |||
| CHIP_CONFIG_RMP_DEFAULT_MAX_RETRANS); | |||
|
|
|||
| if (mAnalyticsDelegate) | |||
| { | |||
| ReliableMessageAnalyticsDelegate::TransmitEvent event = { .nodeId = destination, | |||
There was a problem hiding this comment.
TODO needs to move outside of CHIP_PROGRESS_LOGGING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a starting point for MRP events to be sent to some sort of delegate for analytic purposes.
The design is intentionally done in this way to reduce code size within the SDK and is meant for applications such as a controller to registers a delegate so code size create but adding this in is completely up to the application to make
Testing
./scripts/build/build_examples.py --target linux-x64-tests build