RHOAIENG-8098 - ClusterConfiguration should support tolerations #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
from
72401c0 to
2f2cdca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 90.40% 90.43% +0.02%
==========================================
Files 23 23
Lines 1355 1359 +4
==========================================
+ Hits 1225 1229 +4
Misses 130 130 ☔ View full report in Codecov by Sentry. |
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
2 times, most recently
from
3ab687e to
f3cb22e
Compare
KPostOffice
reviewed
Jan 7, 2025
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
from
f3cb22e to
c5c73f5
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Bobbins228
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Hey Karel looks good, can you address Kevin's comment and add documentation under cluster-configuration.
I am going to give this a test now but this is just my initial review
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
2 times, most recently
from
6271ab5 to
ab15e29
Compare
openshift-merge-robot
added
the
needs-rebase
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
from
ab15e29 to
29065c0
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Thank you @KPostOffice @Bobbins228 for reviews. I've tried to address all the comments. |
Ygnas
reviewed
Jan 8, 2025
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
from
29065c0 to
d637454
Compare
Ygnas
approved these changes
Jan 8, 2025
ChristianZaccaria
previously requested changes
Jan 8, 2025
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
from
d637454 to
77cfe5e
Compare
jiripetrlik
force-pushed
the
RHOAIENG-8098
branch
from
77cfe5e to
d945ad5
Compare
Bobbins228
approved these changes
Jan 8, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit d89ee5a
into
project-codeflare:main
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.