-
Notifications
You must be signed in to change notification settings - Fork 106
[COST-7114] Distribute GPU unallocated at start of month #5846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @myersCody, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the cost distribution mechanism, specifically for unallocated GPU costs, by introducing a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism to delay GPU cost distribution until a full month's data is available, triggering it on the first of the following month. The implementation, however, contains a critical bug where loop variables are modified, which could cause subsequent distributions in the same run to use incorrect date ranges. I've provided a fix for this. Additionally, the new tests have significant code duplication that should be refactored for better maintainability.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5846 +/- ##
=====================================
Coverage 94.3% 94.4%
=====================================
Files 345 345
Lines 29756 29819 +63
Branches 3237 3238 +1
=====================================
+ Hits 28073 28137 +64
- Misses 1098 1100 +2
+ Partials 585 582 -3 🚀 New features to boost your workflow:
|
|
/retest |
|
/retest |
Jira Ticket
COST-7114
Description
This change will make it to where the current month will not distribute GPU unallocated costs.
Testing
Instructions in Jira issue.
Release Notes