style: Fix more sonar issues with core #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalluck
commented
Feb 7, 2025
Comment on lines
+23
to
+34
| private final String message; | ||
|
|
||
| public ApplicationException(String msg, Object... params) { | ||
| super(msg, MessageFormatter.getThrowableCandidate(params)); | ||
| this.params = params; | ||
| this.message = (params != null && params.length != 0) | ||
| ? MessageFormatter.arrayFormat(super.getMessage(), params).getMessage() | ||
| : super.getMessage(); | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized String getMessage() { | ||
| if (formattedMessage == null) { | ||
| formattedMessage = MessageFormatter.arrayFormat(super.getMessage(), params).getMessage(); | ||
| } | ||
| return formattedMessage; | ||
| public String getMessage() { | ||
| return message; |
There was a problem hiding this comment.
Sonar complained about the field formattedMessage.
However, the code itself was, for some reason, initializing the formatted message inside the getMessage() instead of the constructor. Also, params could be null there, which would lead to a NullPointerException, so I guarded against that.
dwalluck
force-pushed
the
sonar-core
branch
11 times, most recently
from
3c9547e to
2869c4e
Compare
dwalluck
commented
Feb 11, 2025
Comment on lines
+470
to
+475
| List<Dependency> updatedDependencies = new ArrayList<>(bom.getDependencies().size()); | ||
| for (Dependency dependency : bom.getDependencies()) { | ||
| updateDependencyRef(dependency, oldRef, newRef); | ||
| updatedDependencies.add(dependency); | ||
| } | ||
| bom.setDependencies(new ArrayList<>(updatedDependencies)); | ||
| bom.setDependencies(updatedDependencies); |
There was a problem hiding this comment.
TreeSet was used for some reason, but the Dependency is not sortable, and ArrayList was the API type anyway.
dwalluck
commented
Feb 11, 2025
Comment on lines
+805
to
+808
| public static List<String> computeNVRFromContainerManifest(JsonNode jsonNode) { | ||
| Bom bom = fromJsonNode(jsonNode); | ||
| if (bom == null || bom.getComponents() == null || bom.getComponents().isEmpty()) { | ||
| return null; | ||
| return List.of(); |
There was a problem hiding this comment.
Converted from primitive array to List, but it may be better to have an NVR type.
vibe13
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.