Skip to content

Improve WebView retry and offline handling#416

Merged
cristhianescobar merged 1 commit intodevelopmentfrom
codex/webview-retry-handling
Mar 9, 2026
Merged

Improve WebView retry and offline handling#416
cristhianescobar merged 1 commit intodevelopmentfrom
codex/webview-retry-handling

Conversation

@cristhianescobar
Copy link
Member

Summary

  • move offline and page-load recovery into the shared Android WebView wrapper used by record store, marketplace, and studio
  • add a dedicated branded WebView error screen with retry support while keeping the shared generic error component reusable
  • tighten internal URL detection to allow only http/https NEWM hosts and add regression coverage for lookalike and custom-scheme links
  • remove presenter-side one-shot connectivity gating and fix studio page-load analytics to log the correct screen

Validation

  • ./gradlew spotlessApply
  • ./gradlew :core-ui:desktopTest
  • ./gradlew :android:app-newm:assembleDevelopmentDebug

Notes

  • no blocking review findings remain after isolating the richer retry UI from the shared ErrorScreen
  • remaining risk is low and mostly around optional follow-up UX, like surfacing a message when an external intent cannot be opened

@cristhianescobar cristhianescobar requested a review from a team as a code owner March 9, 2026 22:19
@cristhianescobar cristhianescobar merged commit 9e47fc1 into development Mar 9, 2026
7 checks passed
@cristhianescobar cristhianescobar deleted the codex/webview-retry-handling branch March 9, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant