Add auto corepining path #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch got upstreamed, shall we just upgrade our VPP version? |
|
Ah forgot we actually use 24.10 here, so LGTM |
hedibouattour
requested changes
Apr 14, 2025
|
And this needs a run of |
This patch adds support in VPP for pinning workers to the CPU
cores that are assigned by a static allocator.
When k8s is configured to run with a static allocator [0]
and that VPP starts with requests.CPU equal to limits.CPU
and both integer numbers.
having VPP configured with
cpu {
main-core 0
corelist-workers 2-3
relative
}
Will make it so that numbers 0,2,3 do not refer to absolutes CPU
IDs but to the 0th, 2nd and 3rd CPU of those allotted by the static
core allocator in k8s.
[0] https://kubernetes.io/docs/tasks/administer-cluster/cpu-management-policies/#static-policy
Signed-off-by: Nathan Skrzypczak <[email protected]>
sknat
force-pushed
the
nsk-cp-corepinning
branch
from
3bd8223 to
ea2e520
Compare
hedibouattour
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support in VPP for pinning workers to the CPU cores that are assigned by a static allocator.
When k8s is configured to run with a static allocator [0] and that VPP starts with requests.CPU equal to limits.CPU and both integer numbers.
having VPP configured with
Will make it so that numbers 0,2,3 do not refer to absolutes CPU IDs but to the 0th, 2nd and 3rd CPU of those allotted by the static core allocator in k8s.
[0] https://kubernetes.io/docs/tasks/administer-cluster/cpu-management-policies/#static-policy