fix auto hep behavior #734
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A normal hep is expected to deny all traffic if no policies are specified that is not the case for an auto hep, as it should allow all traffic using the default allow profile. Here we remove the implicit deny all policy in the case where there are profiles applied. We also give workloadToHostPolicy priority over failsafe rules to comply with calico.
hedibouattour
force-pushed
the
fix-auto-host-endpoint-behavior
branch
from
c439b8d to
8455756
Compare
|
superseded by #753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a normal hep is expected to deny all traffic if no policies are specified that is not the case for an auto hep, as it should allow all traffic using the default allow profile. Here we remove the implicit deny all policy in the case of an auto hep.
this also adds the behavior: empty (non auto) hep should deny all.
And fixes the order of Failsafe rules and other rules that have a higher priority.