Skip to content

Add build to test #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add build to test #2798

wants to merge 2 commits into from

Conversation

@Yelinz
Copy link
Member

@Yelinz Yelinz commented Sep 12, 2024

Deploy to gh-pages on main fails due to build error, this should catch those errors in the future.

@Yelinz Yelinz requested a review from anehx September 12, 2024 10:10
@Yelinz Yelinz self-assigned this Sep 12, 2024
@anehx
Copy link
Contributor

anehx commented Nov 25, 2024

Why do we need corepack for the husky hooks? Not everyone is using corepack and this might break their setup..

@Yelinz
Copy link
Member Author

Yelinz commented Dec 9, 2024

I think it was because packageManager is set in package.json which breaks setups when corepack is installed but not used (because pnpm is used directly). It will complain the version is not matching and not run the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anehx anehx Awaiting requested review from anehx

Assignees

@Yelinz Yelinz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yelinz @anehx